Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce error pollution even more on post request failures #1140

Merged
merged 12 commits into from
Sep 23, 2024

Conversation

melroy89
Copy link
Member

@melroy89 melroy89 commented Sep 19, 2024

This will fix the 16th miscellaneous issue, with too much verbose error logging.

I try to handle the post request basically the same way as the previously implemented InvalidApPostException exceptions like in the getCollectionObjectImpl function.

This meaning the content logging will be part of the catch -> logRequestException function instead. And the InvalidApPostException exception will only log the request body, but no longer the response content. Also we log the status code now as well for failed post requests. Plus some small refactoring.

Last but not least, I will only do a json_encode once.

@melroy89 melroy89 added bug Something isn't working enhancement New feature or request labels Sep 19, 2024
@melroy89 melroy89 added this to the v1.7.2 milestone Sep 19, 2024
@melroy89 melroy89 enabled auto-merge (squash) September 21, 2024 12:04
@melroy89
Copy link
Member Author

I'm running this for 4 days without any issues at kbin.melroy.org

@melroy89 melroy89 merged commit f0d29f4 into main Sep 23, 2024
7 checks passed
@melroy89 melroy89 deleted the reduce_error_pollution_more branch September 23, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants